-
Notifications
You must be signed in to change notification settings - Fork 136
[Tooling] Update release-toolkit to fix milestone moving issue
#14715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Gemfile
Outdated
| # The '>= 13.5.1' after '~> 13.5' ensures that we resolve to any version compatible with 13.5 starting from 13.5.1 | ||
| # We need 13.5.1 because of a fix in fetching issues / PRs with a fine-grained GitHub token | ||
| gem 'fastlane-plugin-wpmreleasetoolkit', '~> 13.5', '>= 13.5.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💄 This is fine, though tbh ~> 13.5 could also have been enough as long as you made sure to re-run bundle update fastlane-plugin-wpmreleasetoolkit once 13.5.1 was deployed so that the dependency resolution would discover it and pick it.
(As long as the Gemfile.lock lockfile is on a version that is >=13.5.1 after you do such update, there's no way it would risk regressing to 13.5.0 later on)
But I don't mind being explicit in the Gemfile even if the Gemfile.lock would have already resolved it to 13.5.1, both are valid anyway 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yeah I was basically following what the Gemfile on iOS had, I've seen this pattern in a few of our Gemfiles. Tbh I'd prefer not to be redundant... and these comments are bound to be out of date / not relevant anyway while dependencies are getting updated (like the previous iOS one did).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated on acf8e1b, favoring a clean-up.
…te fastlane-plugin-wpmreleasetoolkit` h/t @AliSoftware #14715 (comment)
…te fastlane-plugin-wpmreleasetoolkit` h/t @AliSoftware woocommerce/woocommerce-android#14715 (comment)
…te fastlane-plugin-wpmreleasetoolkit` h/t @AliSoftware woocommerce/woocommerce-android#14715 (comment)
…te fastlane-plugin-wpmreleasetoolkit` h/t @AliSoftware #14715 (comment)
acf8e1b to
90040b4
Compare
Follow-up to AINFRA-1359
Description
This PR uses the 13.5.1 release-toolkit version that fixes the action
update_assigned_milestoneto work with fine-grained GitHub tokens (see PR wordpress-mobile/release-toolkit#663).